Fix activeipcollector get_timestamp function implementation and its broken timezone-naive test
#2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the test suite on a machine set to the UTC timezone, `test_find_timestamp` would fail, because the datetime object used to seed the value is timezone-naive. The test would work fine in UTC+1 timezones, but not in other timezones.
No need to get convoluted about how a unix timestamp is derived from a datetime object - it's right there in its methods. Also adds type annotations to make it easer to reason about what the arguments and results are.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2831 +/- ##
=======================================
Coverage 57.10% 57.10%
=======================================
Files 567 567
Lines 41278 41278
=======================================
Hits 23571 23571
Misses 17707 17707 ☔ View full report in Codecov by Sentry. |
hmpf
requested changes
Feb 28, 2024
hmpf
approved these changes
Feb 29, 2024
stveit
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't test epoch values against naive datetimes
When running the test suite on a machine set to the UTC timezone,
test_find_timestampwould fail, because the datetime object used to seed the value is timezone-naive. The test would work fine in UTC+1 timezones, but not in other timezones.This also refactors the convoluted logic of the function itself.