Remove try-except block that does nothing #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothing in there can ever raise a ldap.Error. my guess this is copy pasted from a bit further up in the same function
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2835 +/- ##
==========================================
+ Coverage 57.06% 57.10% +0.04%
==========================================
Files 567 567
Lines 41289 41275 -14
==========================================
+ Hits 23561 23570 +9
+ Misses 17728 17705 -23 ☔ View full report in Codecov by Sentry. |
lunkwill42
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Yeah, I saw that when reviewing #2813 and was thinking "WTH is this?"
Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing in there can ever raise a ldap.Error. my guess this is copy pasted from a bit further up in the same function