Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show NAV logo on mobile in the docs #2837

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Show NAV logo on mobile in the docs #2837

merged 4 commits into from
Feb 28, 2024

Conversation

johannaengland
Copy link
Contributor

Closes #2834.

@johannaengland johannaengland added documentation Related to documentation of NAV frontend labels Feb 28, 2024
@johannaengland johannaengland self-assigned this Feb 28, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.10%. Comparing base (2f19a39) to head (4423dec).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2837   +/-   ##
=======================================
  Coverage   57.10%   57.10%           
=======================================
  Files         567      567           
  Lines       41278    41278           
=======================================
  Hits        23571    23571           
  Misses      17707    17707

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited
Loading

Test results

     12 files       12 suites   11m 34s ⏱️
3 303 tests 3 303 ✔️ 0 💤 0 ❌
9 384 runs  9 384 ✔️ 0 💤 0 ❌

Results for commit 4423dec.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johannaengland johannaengland marked this pull request as ready for review February 28, 2024 12:59
lunkwill42
lunkwill42 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm!

@johannaengland johannaengland merged commit cbdf13f into Uninett:master Feb 28, 2024
12 checks passed
@johannaengland johannaengland deleted the docs/logo-on-mobile branch February 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@hmpf hmpf Awaiting requested review from hmpf

@stveit stveit Awaiting requested review from stveit

@podliashanyk podliashanyk Awaiting requested review from podliashanyk

Assignees

@johannaengland johannaengland

Labels
documentation Related to documentation of NAV frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show NAV logo on mobile in the docs
2 participants
@johannaengland @lunkwill42