Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings during integration tests #2858

Merged

Conversation

johannaengland
Copy link
Contributor

Closes #2847.

I was not able to reproduce

tests/integration/watchdog_test.py::test_get_status_cache_does_not_raise
  /source/.tox/integration-py310-django32/lib/python3.10/site-packages/django/core/cache/backends/filebased.py:36: RuntimeWarning: Pickled model instance's Django version 3.2.23 does not match the current version 3.2.24.
    return pickle.loads(zlib.decompress(f.read()))

@johannaengland johannaengland self-assigned this Mar 4, 2024
@johannaengland johannaengland force-pushed the fix-warning-integration-tests branch from 82d987b to ddef28b Compare March 4, 2024 12:48
@hmpf
Copy link
Contributor

hmpf commented Mar 4, 2024

(Pickle-versions) there's a reason we want to stop using pickle everywhere :)

python/nav/ipdevpoll/jobs.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.69%. Comparing base (9cfd877) to head (6e41330).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2858   +/-   ##
=======================================
  Coverage   56.69%   56.69%           
=======================================
  Files         602      602           
  Lines       43971    43971           
=======================================
  Hits        24931    24931           
  Misses      19040    19040           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but @lunkwill42 needs to okay it , and see my question.

Copy link

github-actions bot commented Mar 4, 2024

Test results

     12 files       12 suites   11m 39s ⏱️
3 320 tests 3 320 ✔️ 0 💤 0
9 435 runs  9 435 ✔️ 0 💤 0

Results for commit 6e41330.

♻️ This comment has been updated with latest results.

@hmpf hmpf self-requested a review March 5, 2024 12:39
@johannaengland johannaengland force-pushed the fix-warning-integration-tests branch from ddef28b to e571b59 Compare March 5, 2024 13:36
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johannaengland johannaengland force-pushed the fix-warning-integration-tests branch from e571b59 to 6e41330 Compare March 7, 2024 14:27
@johannaengland johannaengland merged commit 3c26402 into Uninett:master Mar 8, 2024
11 checks passed
@johannaengland johannaengland deleted the fix-warning-integration-tests branch March 8, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix warnings during integration tests
3 participants