Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to produce QR codes #2887

Merged
merged 1 commit into from
May 16, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Apr 29, 2024

First step for #2586.

Not used anywhere yet, just the first step. Can be tested by changing the function itself to save the picture using img.save(path).
I am uncertain about the way of getting the font, but to be able to change the font size we need to get a font from somewhere.

@johannaengland johannaengland self-assigned this Apr 29, 2024
@johannaengland johannaengland marked this pull request as draft April 29, 2024 12:54
Copy link

github-actions bot commented Apr 29, 2024

Test results

     12 files       12 suites   11m 48s ⏱️
3 322 tests 3 322 ✔️ 0 💤 0
9 441 runs  9 441 ✔️ 0 💤 0

Results for commit 68a368d.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 60.25%. Comparing base (b1cdf9a) to head (b7f9e65).

Files Patch % Lines
python/nav/web/utils.py 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2887      +/-   ##
==========================================
+ Coverage   60.23%   60.25%   +0.02%     
==========================================
  Files         602      602              
  Lines       44050    44084      +34     
==========================================
+ Hits        26534    26565      +31     
- Misses      17516    17519       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland force-pushed the qr-codes branch 2 times, most recently from 4fe7622 to f37d337 Compare April 30, 2024 13:54
@johannaengland johannaengland changed the title Produce QR codes for links to rooms and IP devices Add functionality to produce QR codes Apr 30, 2024
@johannaengland johannaengland requested review from hmpf and stveit April 30, 2024 13:57
@johannaengland johannaengland marked this pull request as ready for review April 30, 2024 13:58
@johannaengland johannaengland force-pushed the qr-codes branch 4 times, most recently from ebbcb45 to 3257306 Compare May 6, 2024 13:39
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, just see some inline suggestions :)

python/nav/web/utils.py Show resolved Hide resolved
changelog.d/2887.added.md Outdated Show resolved Hide resolved
python/nav/web/utils.py Outdated Show resolved Hide resolved
@johannaengland johannaengland merged commit 513c0e4 into Uninett:master May 16, 2024
11 checks passed
@johannaengland johannaengland deleted the qr-codes branch May 16, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants