Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax for branches-ignore in publish tests results #2921

Conversation

johannaengland
Copy link
Contributor

We have observed that after merging #2914 no test reports have been published, after observing #2920 and looking at the documentation for branches-ignore I realized that the syntax looks a bit different...Let's hope this fixes it.

@johannaengland johannaengland requested a review from lunkwill42 May 16, 2024 11:35
@johannaengland johannaengland self-assigned this May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.25%. Comparing base (1aec729) to head (8a2488a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2921   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files         602      602           
  Lines       44084    44084           
=======================================
  Hits        26565    26565           
  Misses      17519    17519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland
Copy link
Contributor Author

Workflows that are triggered by workflow_run are by default always run on master which is why it obviously does not work now, so the syntax has nothing to do with this

@johannaengland johannaengland deleted the workflows/fix-syntax-ignore-branches branch May 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant