Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parse_arp index agnostic #2925

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

Slenderman00
Copy link
Contributor

This resolves #2924 by making the parse_arp function index agnostic.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.27%. Comparing base (0f81276) to head (4f4e8df).
Report is 13 commits behind head on 5.10.x.

Additional details and impacted files
@@           Coverage Diff           @@
##           5.10.x    #2925   +/-   ##
=======================================
  Coverage   60.27%   60.27%           
=======================================
  Files         602      602           
  Lines       44098    44099    +1     
=======================================
+ Hits        26579    26580    +1     
  Misses      17519    17519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 23, 2024

Test results

     12 files       12 suites   11m 45s ⏱️
3 326 tests 3 326 ✔️ 0 💤 0
9 453 runs  9 453 ✔️ 0 💤 0

Results for commit 4f4e8df.

♻️ This comment has been updated with latest results.

@lunkwill42 lunkwill42 changed the base branch from master to 5.10.x May 27, 2024 08:47
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I rebased this on the 5.10.x branch and forced-pushed back to your fork, since this is a bugfix for the 5.10 stable series. Also removed the empty "trigger" commit :)

@lunkwill42 lunkwill42 merged commit f3a2c94 into Uninett:5.10.x May 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins paloaltoarp.py - Entries node not found at element [0][4]
2 participants