-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename snmptrapd
command line program to navtrapd
#2926
Conversation
The name conflicts with Net-SNMP's `snmptrapd` program. The Net-SNMP utilities are a very common companion to a NAV install, so the struggle is real.
Reference the new name of the command line program
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.10.x #2926 +/- ##
=======================================
Coverage 60.27% 60.27%
=======================================
Files 602 602
Lines 44099 44099
=======================================
Hits 26580 26580
Misses 17519 17519 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not also rename the nav.bin.snmptrapd
file itself? Partly renaming seems like something that could be confusing
Simply because it's more work (than a simple bugfix) :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge this now, do the internal rename(s) in a later patch-release so that we can get feedback on the new externally visible name as soon as possible.
Fixes #2882
This really just renames the installed "binary", it does not change the internal module names or references otherwise.