Fix various issues with running test suite on "non-standard" platforms #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS' System Integrity Protection wreaks havoc with NAV and its test suite, due to its dependency on pynetsnmp / NET-SNMP: pynetsnmp will load libcrypto using ctypes, which aborts the python process on MacOS with an error message like this: > WARNING: .tox/integration-py39-django32/bin/python is loading libcrypto > in an unsafe way When OpenSSL is installed on MacOS through homebrew, the environment variable DYLD_LIBRARY_PATH must be set for processes to load the correct version of libcrypto. However, newer versions of MacOS sanitizes this environment variable on many levels. The whole debaucle of trying to fix this in a sane way is described at https://hynek.me/articles/macos-dyld-env/ This workaround is no prettier, and will only work if libssl is installed using Homebrew, or if the value of DYLD_LIBRARY_PATH can be gleaned from LD_LIBRARY_PATH.
The epollreactor2 implementation is no good on other platforms. Without this, the test suite would not run on MacOS, e.g.
Test results 9 files 9 suites 8m 12s ⏱️ For more details on these errors, see this check. Results for commit 796a6a1. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2965 +/- ##
=======================================
Coverage 56.36% 56.37%
=======================================
Files 602 602
Lines 43818 43822 +4
Branches 48 48
=======================================
+ Hits 24700 24703 +3
- Misses 19106 19107 +1
Partials 12 12 ☔ View full report in Codecov by Sentry. |
At least two or three of NAVs dependencies may need to be built from source when pulled in by pip: psycopg2, python-ldap and Pillow. On platforms like NixOS, the include files for the necessary C libraries may not be in standardized FHS locations, so the C_INCLUDE_PATH is used to convey their locations to the C compiler.
lunkwill42
changed the title
johannaengland
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts MacOS and NixOS-related commits from #2675 . They should not affect the test suite on Debian-derived or FHS-compatible Linux OS-es, but will aid in making it run properly on MacOS or NixOS.