Fix various test skip logic issues #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sudo -nv` can be used to verify whether the sudo command is prepared to execute commands non-interactively, i.e. it will not ask for a password. If the password has already been cached by previous sudo commands, or sudo is configured to give passwordless access, we can move on. Otherwise, interactive sudo or lack of sudo access cannot be used to run tests in an automated fashion.
Some pping tests require starting up the pping daemon and killing it after some time. These tests seem to rely on the external `timeout` program, which isn't always available on a system (e.g. it's not available on MacOS).
The python tidylib module loads the system library dynamically. This ensure we skip the HTML validation tests if tidylib isn't properly installed.
If nbtscan is not available (it is, after all, an optional dependency of NAV), netbiostracker.py cannot run, so we might as well skip it.
These tests are supposed to be skipped if we CANNOT be root, not if we *can*.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 21s ⏱️ Results for commit eabd099. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3015 +/- ##
=======================================
Coverage 60.45% 60.45%
=======================================
Files 605 605
Lines 43801 43801
Branches 48 48
=======================================
Hits 26482 26482
Misses 17307 17307
Partials 12 12 ☔ View full report in Codecov by Sentry. |
3 tasks
|
Returning to draft mode- This did not have the intended effect, as many tests were now skipped for reasons unknown... |
Too broad exception catching caused a `NameError` to be masked and all the tests to be skipped: The `get_root_method` function was not available at test definition time, since it was defined below the tests. This narrows the exception catcher and moves the `get_root_method()` before the first test is defined.
lunkwill42
force-pushed
the
test/fix-skip-issue
branch
from
4d28efb to
bf85f9f
Compare
LDAP *is* marked as an optional dependency, so the test suite should still complete without it.
lunkwill42
force-pushed
the
test/fix-skip-issue
branch
from
bf85f9f to
936aa34
Compare
|
Found several more issues that were revealed only by pushing this PR to GitHub in the first place :-) |
johannaengland
approved these changes
Sep 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various fixes to the test suite, all extracted from #2675: