Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default rules for ruff #3045

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Use default rules for ruff #3045

merged 1 commit into from
Nov 29, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 27, 2024

Ignored rules: Module level import not at top of cell, bare except, lambda assignments, star imports

As usual, this is up for discussion which rules we would like to have and which not.

Dependent on #3035.
After this is merged #3005 can be merged as well.

@johannaengland johannaengland added cleanup blocked discussion Requires developer feedback/discussion before implementation labels Sep 27, 2024
@johannaengland johannaengland self-assigned this Sep 27, 2024
Copy link

sonarcloud bot commented Sep 27, 2024

Copy link

github-actions bot commented Sep 27, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 994 0 12.94s
✅ PYTHON ruff 990 0 0.11s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Sep 27, 2024

Test results

    9 files      9 suites   8m 37s ⏱️
2 147 tests 2 147 ✅ 0 💤 0 ❌
4 033 runs  4 033 ✅ 0 💤 0 ❌

Results for commit 41c8af1.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.33%. Comparing base (d385dca) to head (41c8af1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3045   +/-   ##
=======================================
  Coverage   60.33%   60.33%           
=======================================
  Files         606      606           
  Lines       43700    43700           
  Branches       48       48           
=======================================
  Hits        26366    26366           
  Misses      17322    17322           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ignored rules: Module level import not at top of cell, bare except, lambda assignments, star imports
Copy link

sonarcloud bot commented Nov 29, 2024

@johannaengland johannaengland merged commit 8b6953c into master Nov 29, 2024
12 of 13 checks passed
@johannaengland johannaengland deleted the ruff/add-rules branch November 29, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup discussion Requires developer feedback/discussion before implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants