Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispify ManualDetentionForm #3171

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Nov 7, 2024

Fixes #3170

Relies on #3169

Its the second-step form after entering an IP address/mac address into http://localhost/arnold/manualdetention/

@stveit stveit added the refactor label Nov 7, 2024
@stveit stveit self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.72s
✅ PYTHON ruff 987 0 0.11s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Nov 7, 2024

Test results

    9 files      9 suites   8m 18s ⏱️
2 138 tests 2 138 ✅ 0 💤 0 ❌
4 015 runs  4 015 ✅ 0 💤 0 ❌

Results for commit 19a9ad2.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (842754e) to head (19a9ad2).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3171   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         605      605           
  Lines       43705    43703    -2     
  Branches       48       48           
=======================================
  Hits        26394    26394           
+ Misses      17299    17297    -2     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stveit stveit force-pushed the uncrispify/ManualDetentionForm branch from c14a146 to fd48cfe Compare November 8, 2024 08:51
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@stveit stveit force-pushed the uncrispify/add-div-class branch from 17076c0 to 64ec82a Compare November 13, 2024 08:12
Base automatically changed from uncrispify/add-div-class to master November 13, 2024 10:47
@stveit stveit force-pushed the uncrispify/ManualDetentionForm branch from fd48cfe to 9d209ab Compare November 13, 2024 11:05
@stveit stveit force-pushed the uncrispify/ManualDetentionForm branch from 9d209ab to 19a9ad2 Compare November 13, 2024 11:14
Copy link

sonarcloud bot commented Nov 13, 2024

@stveit stveit merged commit f6bb3f3 into master Nov 13, 2024
13 of 14 checks passed
@stveit stveit deleted the uncrispify/ManualDetentionForm branch November 13, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python/nav/web/arnold/forms.py:ManualDetentionForm
2 participants