Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-crispy checkbox #3182

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add non-crispy checkbox #3182

merged 1 commit into from
Nov 13, 2024

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Nov 12, 2024

Replacement for the crispy-reliant Checkbox. Needed for #3174

I think only DetentionProfileForm uses this, so once that is uncrispified this new checbox should probably be renamed to just "CheckBox" and the old be removed

@stveit stveit self-assigned this Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.25s
✅ PYTHON ruff 987 0 0.11s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Nov 12, 2024

Test results

    9 files      9 suites   8m 27s ⏱️
2 139 tests 2 139 ✅ 0 💤 0 ❌
4 017 runs  4 017 ✅ 0 💤 0 ❌

Results for commit 549e4c5.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (82792c5) to head (549e4c5).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3182      +/-   ##
==========================================
- Coverage   60.39%   60.39%   -0.01%     
==========================================
  Files         605      605              
  Lines       43701    43705       +4     
  Branches       48       48              
==========================================
+ Hits        26393    26395       +2     
- Misses      17296    17298       +2     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small comment

And it might be helpful to create an issue to remember to remove CheckBox when #3174 is done.

python/nav/web/crispyforms.py Outdated Show resolved Hide resolved
@stveit stveit requested a review from podliashanyk November 13, 2024 10:54
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@stveit stveit force-pushed the uncrispify/add-non-crispy-checkbox branch from 114e8ff to e9adc63 Compare November 13, 2024 14:22
When old checkbox is removed this should prob be
renamed to just "CheckBox"
@stveit stveit force-pushed the uncrispify/add-non-crispy-checkbox branch from e9adc63 to 549e4c5 Compare November 13, 2024 14:23
Copy link

sonarcloud bot commented Nov 13, 2024

@stveit stveit merged commit 9db1bbf into master Nov 13, 2024
11 of 12 checks passed
@stveit stveit deleted the uncrispify/add-non-crispy-checkbox branch November 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants