-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-crispy checkbox #3182
Add non-crispy checkbox #3182
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 27s ⏱️ Results for commit 549e4c5. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3182 +/- ##
==========================================
- Coverage 60.39% 60.39% -0.01%
==========================================
Files 605 605
Lines 43701 43705 +4
Branches 48 48
==========================================
+ Hits 26393 26395 +2
- Misses 17296 17298 +2
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small comment
And it might be helpful to create an issue to remember to remove CheckBox
when #3174 is done.
python/nav/web/templates/custom_crispy_templates/form_checkbox.html
Outdated
Show resolved
Hide resolved
python/nav/web/templates/custom_crispy_templates/form_checkbox.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
114e8ff
to
e9adc63
Compare
When old checkbox is removed this should prob be renamed to just "CheckBox"
e9adc63
to
549e4c5
Compare
Quality Gate passedIssues Measures |
Replacement for the crispy-reliant
Checkbox
. Needed for #3174I think only
DetentionProfileForm
uses this, so once that is uncrispified this new checbox should probably be renamed to just "CheckBox" and the old be removed