Uncrispify room/location status navlet html template #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 21s ⏱️ Results for commit 9a48d85. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3198 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 605 605
Lines 43690 43690
Branches 48 48
=======================================
Hits 26386 26386
Misses 17292 17292
Partials 12 12 ☔ View full report in Codecov by Sentry. |
4 tasks
johannaengland
force-pushed
the
refactor/uncrispify-room-status-navlet
branch
from
42b6b7b to
ac8554a
Compare
stveit
requested changes
Nov 15, 2024
python/nav/web/templates/navlets/room_location_status_edit.html
Outdated
Show resolved
Hide resolved
stveit
approved these changes
Nov 15, 2024
johannaengland
force-pushed
the
refactor/uncrispify-room-status-navlet
branch
from
bb9a43d to
9a48d85
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked in #3137.
Add a widget "Locations with active alerts"/"Rooms with active alerts" and click on edit