Remove unused userinfo template #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
1 task
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 6s ⏱️ Results for commit 463491a. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3203 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 605 605
Lines 43699 43699
Branches 48 48
=======================================
Hits 26390 26390
Misses 17297 17297
Partials 12 12 ☔ View full report in Codecov by Sentry. |
stveit
approved these changes
Nov 14, 2024
This has been replaced by the preference template in 5c5accd
johannaengland
force-pushed
the
cleanup/remove-unused-userinfo-template
branch
from
6eb90b5 to
463491a
Compare
|
|
Last reference was 11 years ago, when the code using the template was removed in 5c5accd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was searching far and wide for where this template was being used and first assumed it might be confusing as navlets is, but I came to the conclusion that it is actually not in use any longer since 5c5accd.
It has been replaced by
web/templates/webfront/preferences.html.So this helps us in uncrispifying in the way that we can simply delete it.