Cancel scheduled maintenance tasks when all their components are missing #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During task state transition updates, if there are active maintenance tasks that don't reference any non-deleted components, take care to cancel it. It only makes sense to cancel active tasks. Scheduled tasks could still be in the process of being edited by an admin, and we don't want to alter them under the users' nose.
lunkwill42
requested review from
andreassolberg and
johannaengland
and removed request for
andreassolberg
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 40s ⏱️ Results for commit fa8994b. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3235 +/- ##
==========================================
+ Coverage 60.39% 60.41% +0.02%
==========================================
Files 605 605
Lines 43687 43695 +8
Branches 48 48
==========================================
+ Hits 26383 26398 +15
+ Misses 17292 17285 -7
Partials 12 12 ☔ View full report in Codecov by Sentry. |
johannaengland
approved these changes
Nov 26, 2024
lunkwill42
deleted the
feature/cancel-maintenance-tasks-without-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
maintengineto automatically cancel active maintenance tasks if they have no valid components referenced (i.e. if the task has 0 components, or all referenced components have been deleted from the database).It does not cancel scheduled tasks, as they may still become valid before they are activated (someone could still be editing them).
Fixes #3229
Fixed #2243