-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list limits for alert profiles dropdowns #3239
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 30s ⏱️ Results for commit 6259afc. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3239 +/- ##
=======================================
Coverage 60.30% 60.30%
=======================================
Files 605 605
Lines 43685 43685
Branches 48 48
=======================================
Hits 26343 26343
Misses 17330 17330
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is that there is still a word missing in the commit message and that the SQL file should be renamed
Why should it be renamed? |
Because currently it is |
If you want to be square about it, the next free number on master is in fact The number itself means nothing, it is just that migration scripts will be run in numerical order (but anyone who runs the |
For some long-forgotten reason, there are limits configured on the length of dropdown lists in Alert Profiles: One value per match field is set in the database. The limits are set to 1000 for all fields, but some users do in fact have more than 1000 communication rooms registered in their NAV installations. The code does not allow unlimited lengths, so a quickfix for now is to increase the limit ten-fold. A more long-term fix would be to look into why there are limitations at all (aside from the fact that selecting from a dropdown with > 1000 values and no search functionality is bad UX)
6259afc
to
ac5267c
Compare
Quality Gate passedIssues Measures |
For some long-forgotten reason, there are limits configured on the length of dropdown lists in Alert Profiles: One value per match field is set in the database. The limits are set to 1000 for all fields, but some users do in fact have more than 1000 communication rooms registered in their NAV installations.
The code does not allow unlimited lengths, so a quickfix for now is to increase the limit ten-fold. A more long-term fix would be to look into why there are limitations at all (aside from the fact that selecting from a dropdown with > 1000 values and no search functionality is bad UX)
Fixes #2908