Select generic SNMPHandler for Cisco Small Business switches in PortAdmin
#3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing netbox mock fixtures needed to be updated with proper sysObjectID value mocking as well, since the selection logic for handlers will become more complex.
Cisco small business switches do not actually work like other Cisco products SNMP-wise, and we need to revert to the generic handler to make them work with PortAdmin
This pushes the logic of PortAdmin management handler selection to the handlers themselves, making it easier to implement more complex selection logic if needed. It seems more correct to let the handler classes decide for themselves whether a given Netbox is compatible. A `can_handle()` class method is added to `ManagementHandler`, whose default implementation is based on the existing "selection by `VENDOR` id" scheme. The extra logic for Cisco-but-not-quite-Cisco can therefore be pushed into a specific `can_handle()` implementation for the Cisco handler.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 13s ⏱️ Results for commit b6c327d. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3250 +/- ##
=======================================
Coverage 60.33% 60.34%
=======================================
Files 606 606
Lines 43700 43710 +10
Branches 48 48
=======================================
+ Hits 26366 26376 +10
Misses 17322 17322
Partials 12 12 ☔ View full report in Codecov by Sentry. |
stveit
reviewed
Dec 3, 2024
johannaengland
approved these changes
Dec 3, 2024
Make the fallback algorithm more explicit, as per code review comments.
|
johannaengland
approved these changes
Dec 4, 2024
stveit
approved these changes
Dec 4, 2024
lunkwill42
deleted the
feature/portadmin-select-generic-handler-for-ciscosmb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3249 in two rounds, after introducing/updating tests for the issue at hand: