Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Github workflows to ubuntu-22.04 image #3253

Closed
wants to merge 1 commit into from

Conversation

lunkwill42
Copy link
Member

ubuntu-latest has moved to 24.04 and there seems to be problems with running the CI workflows on that version. This locks all workflows to ubuntu-22.04 until we can figure out the issues.

ubuntu-latest has moved to 24.04 and there seems to be problems with
running the CI workflows on that version.  This locks all workflows
to ubuntu-22.04 until we can figure out the issues.
Copy link

sonarcloud bot commented Dec 11, 2024

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

Test results

    9 files      9 suites   8m 33s ⏱️
2 158 tests 2 158 ✅ 0 💤 0 ❌
4 055 runs  4 055 ✅ 0 💤 0 ❌

Results for commit 45fe42a.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.54%. Comparing base (4b527c8) to head (45fe42a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3253      +/-   ##
==========================================
- Coverage   60.55%   60.54%   -0.01%     
==========================================
  Files         606      606              
  Lines       43723    43723              
  Branches       48       48              
==========================================
- Hits        26478    26474       -4     
- Misses      17233    17237       +4     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lunkwill42 lunkwill42 requested a review from hmpf December 11, 2024 09:55
@lunkwill42 lunkwill42 marked this pull request as ready for review December 11, 2024 09:55
@lunkwill42 lunkwill42 self-assigned this Dec 11, 2024
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing it's the same stuff that made us lock distro version in argus? That is, system pip behaves very differently now.

@lunkwill42
Copy link
Member Author

I'm guessing it's the same stuff that made us lock distro version in argus? That is, system pip behaves very differently now.

Actually, no.

The problem seems to be the way our Github cache keys are constructed: The same pip cache was re-used when the runner OS was changed - so the workflow began running on Ubuntu 24.04 when GitHub upgraded ubuntu-latest, but the package cache for Ubuntu 22.04 was being re-used. The cache included builds of python-ldap that linked to an older version of libldap.

I was going to make PR for this alternative fix, but I accidentally pushed it directly to master: It seems to have made the test suite run fine again, so I'm opting to close this PR.

Thanks for the review anyway, @hmpf ! :)

@lunkwill42 lunkwill42 closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants