Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make linter more similar to zino #19

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Make linter more similar to zino #19

merged 2 commits into from
Jan 19, 2024

Conversation

johannaengland
Copy link
Contributor

The main fix to the linting problems is setting DEFAULT_BRANCH to main instead of master (dumb copy-paste error).

@johannaengland johannaengland requested a review from hmpf June 26, 2023 10:36
@johannaengland johannaengland self-assigned this Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c9469f) 71.60% compared to head (f49a5d1) 71.60%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   71.60%   71.60%           
=======================================
  Files          13       13           
  Lines        1363     1363           
=======================================
  Hits          976      976           
  Misses        387      387

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Jun 26, 2023 •
edited
Loading

Test results

    3 files      3 suites   41s ⏱️
  63 tests   63 ✔️ 0 💤 0 ❌
189 runs  189 ✔️ 0 💤 0 ❌

Results for commit f49a5d1.

♻️ This comment has been updated with latest results.

@johannaengland johannaengland requested a review from hmpf June 26, 2023 12:52
hmpf
hmpf reviewed Jul 26, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
hmpf
hmpf reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See needed procedure. We're lucky that we have so few branches, on a repo with plenty branches, solving the resulting conflicts would be ulcer-inducing.

@johannaengland johannaengland requested a review from hmpf July 28, 2023 08:52
hmpf
hmpf requested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blindly reformatting test fixtures is not wise, see also other comments.

examples/test-with.py Outdated Show resolved Hide resolved
src/zinolib/ritz.py Outdated Show resolved Hide resolved
tests/atest_mock.py Outdated Show resolved Hide resolved
tests/atest_mock.py Outdated Show resolved Hide resolved
tests/atest_mock.py Outdated Show resolved Hide resolved
tests/atest_mock.py Outdated Show resolved Hide resolved
tests/atest_mock.py Outdated Show resolved Hide resolved
tests/atest_mock.py Outdated Show resolved Hide resolved
tests/test_default.py Outdated Show resolved Hide resolved
@johannaengland johannaengland force-pushed the change-linter-config branch 2 times, most recently from 1fecd50 to ed8129d Compare July 28, 2023 12:21
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
16.1% 16.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@johannaengland johannaengland requested a review from hmpf July 28, 2023 12:31
@johannaengland
Copy link
Contributor Author

SonarCloud is failing due to things in legacy code that is reformatted by the new linters. This PR does not introduce any new code.

@johannaengland
Copy link
Contributor Author

This code should not be merged before squashing all the linting commits and then adding the linting commit to the git-blame ignore file

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johannaengland
Copy link
Contributor Author

I have now removed the formatting with black, ruff and isort.

@hmpf hmpf merged commit 10b6a2c into main Jan 19, 2024
10 checks passed
@hmpf hmpf deleted the change-linter-config branch January 19, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmpf hmpf hmpf approved these changes

Assignees

@johannaengland johannaengland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannaengland @hmpf