Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle sessions, updates and config better #25

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Handle sessions, updates and config better #25

merged 5 commits into from
Oct 20, 2023

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Oct 12, 2023

No description provided.

@hmpf hmpf marked this pull request as draft October 12, 2023 09:02
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Test results

    3 files      3 suites   41s ⏱️
  62 tests   62 ✔️ 0 💤 0 ❌
186 runs  186 ✔️ 0 💤 0 ❌

Results for commit f066d26.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #25 (f066d26) into main (3f3d449) will increase coverage by 0.21%.
Report is 4 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   71.30%   71.51%   +0.21%     
==========================================
  Files          13       13              
  Lines        1143     1271     +128     
==========================================
+ Hits          815      909      +94     
- Misses        328      362      +34
Files Coverage Δ
src/zinolib/controllers/base.py 86.66% <66.66%> (-10.11%) ⬇️
src/zinolib/controllers/zino1.py 72.45% <66.66%> (+1.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hmpf hmpf force-pushed the session-adapter branch 4 times, most recently from f216b81 to 74bc6ca Compare October 17, 2023 06:42
@podliashanyk podliashanyk mentioned this pull request Oct 17, 2023
Closed
2 tasks
@hmpf
Copy link
Contributor Author

hmpf commented Oct 17, 2023

Will be updated once #22 is in.

@hmpf hmpf marked this pull request as ready for review October 18, 2023 11:07
@hmpf hmpf force-pushed the session-adapter branch 2 times, most recently from 6833480 to 3531c18 Compare October 18, 2023 12:00
lunkwill42
lunkwill42 reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good structure to me (once I got what the hell was going on, I don't know zinolib that well). docstrings to explain some of the concepts or usage scenarios of your classes could improve understanding a lot.

Other than that, codecov claims you're just shy of the coverage requirement 😁

src/zinolib/controllers/zino1.py Outdated Show resolved Hide resolved
tests/test_zinolib_controllers_zino1.py Outdated Show resolved Hide resolved
@hmpf hmpf force-pushed the session-adapter branch 2 times, most recently from aba4fe4 to 3388b2d Compare October 20, 2023 09:04
hmpf added 3 commits October 20, 2023 11:09
@hmpf
Add a SessionAdapter
79ebf45 
Prerquisite for improving configuration of the manager.
@hmpf
Add an UpdateHandler
ccaeb86 
Run the ``poll()``-method in a while-loop or similar for real-time
changes.
@hmpf
Make test more generic as per review
11e40c3
@podliashanyk podliashanyk mentioned this pull request Oct 20, 2023
Merged
@hmpf hmpf requested a review from lunkwill42 October 20, 2023 09:15
podliashanyk
podliashanyk approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against Howitz and it works really well 🙌

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hmpf hmpf merged commit 597a2d0 into Uninett:main Oct 20, 2023
8 of 9 checks passed
@hmpf hmpf deleted the session-adapter branch October 20, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@podliashanyk podliashanyk podliashanyk approved these changes

@johannaengland johannaengland Awaiting requested review from johannaengland

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmpf @lunkwill42 @podliashanyk