Set "unknown" bfd_addr to None #38

hmpf · 2023-11-23T14:06:59Z

Closes #37

github-actions · 2023-11-23T14:08:12Z

Test results

    3 files     3 suites 41s ⏱️
  62 tests   62 ✔️ 0 💤 0 ❌
186 runs 186 ✔️ 0 💤 0 ❌

Results for commit e334474.

♻️ This comment has been updated with latest results.

podliashanyk

Tested manually and it works as intended 🙌 Can be merged after failing tests are fixed

src/zinolib/event_types.py

codecov · 2023-11-27T12:58:09Z

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (f066d26) 71.51% compared to head (e334474) 71.92%.
Report is 9 commits behind head on main.

Files	Patch %	Lines
src/zinolib/controllers/zino1.py	60.00%	14 Missing ⚠️
src/zinolib/ritz.py	27.77%	13 Missing ⚠️
src/zinolib/config/zino1.py	57.89%	8 Missing ⚠️
src/zinolib/event_types.py	82.35%	3 Missing ⚠️
src/zinolib/utils.py	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   71.51%   71.92%   +0.41%     
==========================================
  Files          13       13              
  Lines        1271     1343      +72     
==========================================
+ Hits          909      966      +57     
- Misses        362      377      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hmpf · 2023-11-27T12:59:18Z

I rewrote it to use the decorator from #40 instead of manually adding information to any exception in create. Then there's no need to change any tests.