Handle ValueError on setstate on closed event #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmpf
force-pushed
the
valueerror-setstate
branch
from
77021e4 to
30b7cb1
Compare
hmpf
force-pushed
the
valueerror-setstate
branch
from
dd85799 to
6188784
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 71.51% 71.56% +0.04%
==========================================
Files 13 13
Lines 1271 1361 +90
==========================================
+ Hits 909 974 +65
- Misses 362 387 +25 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zinolib.ritz raises a ValueError if setstate does not respond with
(200 , 'Ok'). We know that on setting a state on a closed event we get(500, 'Cannot reopen closed event {event_id}')in the exception message so if we get that, reraise as anEventClosedError. Other potential errors from setstate are let through.