Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for keepalive #63

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Add support for keepalive #63

merged 2 commits into from
Jun 24, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Jun 12, 2024

@hmpf hmpf requested a review from a team June 12, 2024 09:42
@hmpf hmpf self-assigned this Jun 12, 2024
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Test results

    3 files      3 suites   41s ⏱️
  66 tests   66 ✔️ 0 💤 0
198 runs  198 ✔️ 0 💤 0

Results for commit 9e11dac.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.23%. Comparing base (ddfbd8c) to head (aeabe20).
Report is 11 commits behind head on main.

Files Patch % Lines
src/zinolib/utils.py 72.22% 5 Missing ⚠️
src/zinolib/ritz.py 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   70.49%   70.23%   -0.27%     
==========================================
  Files          13       13              
  Lines        1427     1458      +31     
==========================================
+ Hits         1006     1024      +18     
- Misses        421      434      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.. and make keepalive configurable, default: on.
@hmpf hmpf changed the title Add support for keepalive for ntie Add support for keepalive Jun 21, 2024
@hmpf
Copy link
Contributor Author

hmpf commented Jun 21, 2024

After help with experimentation with curitz I have added keepalive to the protocol socket (on 8001) as well.

@hmpf hmpf requested review from a team and runborg June 21, 2024 06:12
@hmpf hmpf merged commit 970cc68 into Uninett:main Jun 24, 2024
6 of 8 checks passed
@hmpf hmpf deleted the keepalive-ntie branch June 24, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification socket gets broken pipe when behind a firewall
2 participants