Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff instead of flake8 to lint files #74

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 35 additions & 43 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
@@ -1,59 +1,51 @@
---
#################################
#################################
## Super Linter GitHub Actions ##
#################################
#################################
name: Lint Code Base

######################################################
# Start the job on all push and pull request to main #
######################################################
# MegaLinter GitHub Action configuration file
# More info at https://megalinter.io
name: MegaLinter
on:
push:
branches: main
pull_request:

###############
# Set the Job #
###############
jobs:
build:
# Name the Job
name: Lint Code Base
# Set the agent to run on
megalinter:
name: MegaLinter
runs-on: ubuntu-latest

############################################
# Grant status permission for MULTI_STATUS #
############################################
permissions:
contents: read
packages: read
statuses: write

##################
# Load all steps #
##################
# Give the linter write permission to comment on PRs (if PR is not from fork)
issues: write
pull-requests: write
steps:
##########################
# Checkout the code base #
##########################
# Git Checkout
- name: Checkout Code
uses: actions/checkout@v4
with:
# Full git history is needed to get a proper
# list of changed files within `super-linter`
token: ${{ secrets.GITHUB_TOKEN }}
fetch-depth: 0

################################
# Run Linter against code base #
################################
- name: Lint Code Base
uses: github/super-linter/slim@v6
# MegaLinter
- name: MegaLinter
id: ml
# You can override MegaLinter flavor used to have faster performances
# More info at https://megalinter.io/flavors/
uses: oxsecurity/megalinter/flavors/python@v8
env:
VALIDATE_ALL_CODEBASE: false
DEFAULT_BRANCH: main
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Add validation for other languages here or comment out all to validate all languages
VALIDATE_PYTHON_FLAKE8: true
# Validate whole codebase on pushes and only changes on pull requests
# FIXME VALIDATE_ALL_CODEBASE: ${{ github.event_name == 'push'}}
VALIDATE_ALL_CODEBASE: true
LINTER_RULES_PATH: .
ENABLE_LINTERS: PYTHON_RUFF
PYTHON_RUFF_CONFIG_FILE: pyproject.toml
# Make workflow fail even on non blocking errors
FORMATTERS_DISABLE_ERRORS: false

# Upload MegaLinter artifacts
- name: Archive production artifacts
if: success() || failure()
uses: actions/upload-artifact@v4
with:
name: MegaLinter reports
path: |
megalinter-reports
mega-linter.log

2 changes: 1 addition & 1 deletion examples/test-with.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def main():
while True:
n = notif.poll()
if n:
print n
print(n)
p = n.split(' ',2)
if "attr" in p[1]:
pprint(sess.get_attributes(int(p[0])))
Expand Down
7 changes: 7 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,10 @@ include = [

[tool.setuptools_scm]
write_to = "src/zinolib/version.py"

[tool.ruff]
line-length = 120
target-version = "py39"

[tool.ruff.lint]
select = ["E9", "F63", "F7", "F82"]
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,4 @@ extend_exclude =
*.egg-info,
*.html,
*.txt,
select = E9,F63,F7,F82
Loading