Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit(15): Document integer overflow in MathExt #307

Merged
merged 1 commit into from
Oct 8, 2024
Merged

audit(15): Document integer overflow in MathExt #307

merged 1 commit into from
Oct 8, 2024

Conversation

alanhwu
Copy link
Collaborator

@alanhwu alanhwu commented Oct 3, 2024

The boundedSub(a, b) and boundedAdd(a, b) functions revert when b == type(int256).min

@alanhwu alanhwu changed the title docs: document integer overflow in MathExt audit(15): document integer overflow in MathExt Oct 3, 2024
@alanhwu alanhwu changed the title audit(15): document integer overflow in MathExt audit(15): ocument integer overflow in MathExt Oct 3, 2024
@alanhwu alanhwu changed the title audit(15): ocument integer overflow in MathExt audit(15): Document integer overflow in MathExt Oct 3, 2024
@alanhwu alanhwu linked an issue Oct 3, 2024 that may be closed by this pull request
audit: 15 #297
Closed
@codyborn codyborn merged commit 7d92c54 into main Oct 8, 2024
3 checks passed
@codyborn codyborn deleted the audit-v3-15 branch October 8, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongeric zhongeric zhongeric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit: 15
3 participants
@alanhwu @zhongeric @codyborn