use nested structs for hashing the relay order #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
zhongeric
approved these changes
Feb 16, 2024
marktoda
approved these changes
Feb 16, 2024
| "FeeEscalator(", | ||
| "address token,", | ||
| "uint256 startAmount,", | ||
| "uint256 endAmount,", |
There was a problem hiding this comment.
previously you were skipping endAmount since it's included in the tokenpermissions - any reason we decided to add it back in?
There was a problem hiding this comment.
Yeah we are changing the entire hash function of the RelayOrder because otherwise order hashes are not collision resistant. Ie a change in endAmount or even the token but everything else is kept the same would result in the same hash
zhongeric
approved these changes
Feb 16, 2024
zhongeric
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Add tests to the relay order lib, needs to merge main