chore: bump SOR to 4.7.2 - fix: add v4 related split routes metrics and routeToString #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cgkol
reviewed
Oct 15, 2024
jsy1218
force-pushed
the
siyujiang/route-328-add-v4-related-split-routes-metrics
branch
from
6ff2d59 to
c69c911
Compare
jsy1218
changed the title
jsy1218
commented
Oct 16, 2024
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (10/16/24)1 assignee was added and 3 reviewers were added to this PR based on 's automation. |
xrsv
approved these changes
Oct 16, 2024
Merge activity
|
jsy1218
deleted the
siyujiang/route-328-add-v4-related-split-routes-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
forgot to emit v4 related split routes metrics
What is the new behavior (if this is a feature change)?
emit v4 related split routes metrics
Other information:
this is to keep track of an edge case, that i dont expect happen frequently https://linear.app/uniswap/issue/ROUTE-303/tech-debt-split-route-can-have-different-ethweth-input-or-output#comment-a0b9a66a