Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add AQTIS token to default allowlist #755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KovacZan
Copy link

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Enables routing for AQTIS V3 Pool.

  • What is the current behavior? (You can also link to an open issue here)
    Executing the following command:

./bin/cli quote --tokenIn 0x6ff2241756549b5816a177659e766eaf14b34429 --tokenOut 0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2 --amount 1000000000000000 --exactIn --recipient 0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B --protocols v3

Returns: Could not find route. Run in debug mode for more info.

  • What is the new behavior (if this is a feature change)?
    After the following change, it returns the correct v3 route path.

  • Other information:

Previously we had v2 pool for AQTIS token, which had transfer fee tax. We eliminated this for V3 Pool.
Another thing to note is that if you change the following number:
https://github.com/KovacZan/smart-order-router/blob/617314a85b84ee954e036407766598653c0e7ab6/src/providers/token-validator-provider.ts#L34
to 20 or 1000000000000000 you get the correct v3 route.

@KovacZan KovacZan requested a review from a team as a code owner October 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant