This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
chore: remove portion flags used for development and control #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeki
requested review from
ConjunctiveNormalForm,
zhongeric,
marktoda and
hensha256
as code owners
jsy1218
reviewed
Apr 24, 2024
| @@ -141,10 +141,6 @@ export class APIPipeline extends Stack { | |||
| secretCompleteArn: 'arn:aws:secretsmanager:us-east-2:644039819003:secret:UniswapX/ParamApi/ApiKeys-hYyUt1', | |||
| }); | |||
|
|
|||
| const portionFlagSecret = sm.Secret.fromSecretAttributes(this, 'portion-flag', { | |||
There was a problem hiding this comment.
once we deploy this PR, we can delete secret portion-flag
jsy1218
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The force-portion secret was used in testing and development, but it is no longer needed now that portion is on by default.
The flag ENABLE_PORTION was used for control, but we now have feature switches in FeeService which we can use to turn on or off the portion.