try-catch-initialize #397
Merged
try-catch-initialize #397
+49
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
previously approved these changes
Nov 22, 2024
hensha256
reviewed
Nov 22, 2024
src/base/PoolInitializer.sol
Outdated
| function initializePool(PoolKey calldata key, uint160 sqrtPriceX96) external payable returns (int24) { | ||
| return poolManager.initialize(key, sqrtPriceX96); | ||
| try poolManager.initialize(key, sqrtPriceX96) returns (int24) {} catch {} |
There was a problem hiding this comment.
i think if you want to return the tick (if we care) then you have to do like
try poolManager.initialize(key, sqrtPriceX96) returns (int24 tick) {
return tick;
} catch {
return 0;
}
i think it currently never returns something
There was a problem hiding this comment.
or you could remove the return parameter
There was a problem hiding this comment.
or you could name the return parameter of initializePool to tick and then do
try poolManager.initialize(key, sqrtPriceX96) returns (int24 _tick) {
tick = _tick;
} catch {}
There was a problem hiding this comment.
happy with any of those 3 solutions :)
There was a problem hiding this comment.
hm actually you dont want to return 0 on failure because thats a valid tick too 😆 i'm pushing a suggestion
hensha256
previously approved these changes
Nov 22, 2024
hensha256
previously approved these changes
Nov 22, 2024
hensha256
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes