Optimize v2 hook #49
Optimize v2 hook #49
Conversation
| @@ -47,13 +48,7 @@ contract FullRange is BaseHook, ILockCallback { | |||
|
|
|||
| struct PoolInfo { | |||
| uint128 liquidity; | |||
There was a problem hiding this comment.
is this liquidity param redundant with the erc20 totalSupply??
There was a problem hiding this comment.
ah it is! i am thinking of getting rid of this liquidity param anyways.
| tickLower: MIN_TICK, | ||
| tickUpper: MAX_TICK, | ||
| liquidityDelta: -int256(int128(position.liquidity)) | ||
| }) |
There was a problem hiding this comment.
confused here....should we be taking out the liquidity as stated by poolManager.getLiquidity() which gets out of sync with our internal position.liquidity here as fees get accumulated? If what I said was true...we woudln't be swapping against a 0 liquidity pool down below....just one with liquidity made up of accrued fees
There was a problem hiding this comment.
yep, fixing it to use poolManager.getLiquidity(). i could also sync up position.liquidity with the fees, which i accidentally removed :'(
There was a problem hiding this comment.
although it adds 300 gas to rebalancing, i assume syncing position.liquidity will add ~200 gas so maybe not a big deal
There was a problem hiding this comment.
yahhh needing to load the context of an external contract I think is at least 200 gas overhead, but I think this makes more sense, and 200 isn't toooo much
|
codes a lot cleaner! |
* in progress full range * rename * in progress * compiling * basic tests passing * erc20 contract deploy * initial liquidity deposit working * removeLiquidity tests * withdrawing liquidity works * merge with main * in progress * compiling code with rebalancing * basic liquidity add tests with fee working * in progress add liq swap tests * debug add liquidity rebalance * simple rebalance working * removing liquidity tests passing but check implementation * add gas snapshots * add blockNumber and liquidity token addr to poolinfo struct, update gas snapshots * update erc20 contract, rerun gas snapshots, remove create2 * readd create2, rerun gas snapshots with create2 * increase amounts used in tests * update tests and debug rebalance * fixed rebalancing dust issue * working tests and fixed rebalancing * fix dependencies * debug lib * some code cleanup and v4-core update * some more cleanup * some more code cleanup * Optimize v2 hook (#49) * sload and swrite on every swap * sload on every swap, only write if need to * remove console.logs * rebalance and reinvest dust with donate * remove no rebalance test * some code cleanup * test cleanup and store poolId * remove liquidity in pool info struct * comment + test cleanup * deploy erc20 with custom liquidity token name * cleanup and add custom tick spacing error * add minimum liquidity * make rebalance public * fuzz testing * clean up tests * in progress pr comment addressing * fix burning liquidity, some code cleanup * uncached storage slot remove liquidity gas test * use safe cast library * fix minimum liquidity error, add price slippage test * address pr comments * fix remove liquidity fuzz test * add fuzz test for swapping and removing all liquidity * add univ4 to erc20 token names * update init snapshot * fix max tick liquidity * custom errors
No description provided.