Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove sirius direct #176

Open
wants to merge 83 commits into
base: New-Antares-Emulator-2
Choose a base branch
from

Conversation

meslubi2021
Copy link
Collaborator

No description provided.

@meslubi2021 meslubi2021 self-assigned this Jul 17, 2024
payetvin and others added 24 commits July 19, 2024 15:54
Mainly add new unit tests for slack analysis.

Also add condition (threshold) on slack variable values.

---------

Co-authored-by: Florian OMNES <[email protected]>
Co-authored-by: Florian Omnès <[email protected]>
9.8-rte1.0 -> 9.10-rte1.0
OR-Tools 9.10-rte1.0 was built with devtoolset-11, so we use the same toolchain to avoid compatibility issues.
Preview
https://antares-simulator--2283.org.readthedocs.build/en/2283/user-guide/solver/05-model/#short-term-storage

- Notations (variables, parameters)
- Added level equation
- Contribution to the existing balance equation
Co-authored-by: Jason Marechal <[email protected]>
Co-authored-by: Jason Maréchal <[email protected]>
- Add "short-tests" study batch to coverage analysis
- Use Release build type for SonarCloud CI (previously Debug) to avoid
saturating the RAM on GH runners (Debug + Coverage instrumentation is a
bit too much)
- (minor) Display error code in case of failure for study tests

---------

Co-authored-by: Florian OMNES <[email protected]>
https://github.com/marketplace/actions/maximize-build-disk-space

```
Run df -h
Filesystem      Size  Used Avail Use% Mounted on
...
/dev/mapper/buildvg-buildlv   85G   24K   85G   1% /home/runner/work/Antares_Simulator/Antares_Simulator
```
Nice
- Take overflows into account for hydro ventilation results
- Update documentation (typos, etc.)

---------

Co-authored-by: Juliette-Gerbaux <[email protected]>
flomnes and others added 29 commits September 11, 2024 14:00
This follows the removal of the "adequacy patch - local matching" feature.
In expressions, replace "AddNode" that takes only 2 operands, with
"SumNode" that takes 0 to N operands.
This will allow shallower trees.

---------

Co-authored-by: Abdoulbari Zaher <[email protected]>
Co-authored-by: Florian Omnès <[email protected]>
Co-authored-by: OMNES Florian <[email protected]>
Update to properly handle new [or-tools-rte
repository](https://github.com/rte-france/or-tools-rte)
close #1719

---------

Co-authored-by: Guillaume PIERRE <[email protected]>
Remove unused `SNPRINTF` macro & other defines
The goal of this PR is to introduce and unit test class
**LinearProblemBuilder**.
This class is an orchestration class, and therefore makes other classes
collaborate.
What was done : 
- Remove **LinearProblemBuilder::solve()** : 
this method was planned in the specifications, but it extends the
builder responsibility scope.
Once modified by the builder, the problem can be solved by calling its
own **solve()** method.
- Add methods **numVariables()** and **numConstraints()** to base class
**ILinearProblem** for unit tests reason.
- **CMakeLists.txt** file for modeler API was split into 2 **\*.cmake**
files
- **Trial for a dependency simplification** :
In the original / specified architecture, **LinearProblemBuilder**
collaborates with classes :
  - **LinearProblemData**
  - **ILinearProblem** (interface for LP)
- **LinearProblemFiller** : this class also depends on previous classes

Here, we allowed ourselves to reduce dependencies of this builder class
(is this simplification relevant ?) :
class **LinearProblemBuilder** currently only depends on
**LinearProblemFiller**, while fillers keeps its planned dependencies on
**LinearProblemData** and **ILinearProblem**.
Indeed, any filler is in charge to modify problem (using LP data), the
but the builder only manipulates fillers.
- **Mocking fillers** : fillers are the entities responsible for
creating variables and constraints in the linear problem. To do that,
they need the LP itself as well as the LP data (see fillers
constructor). We created an abstract base filler. All concrete filler
inherit from it. Class **LinearProblemBuilder** is constructed from a
vector of fillers.
- Several unit tests were created for class **LinearProblemBuilder**

---------

Co-authored-by: Abdoulbari Zaher <[email protected]>
@guilpier-code guilpier-code deleted the feature/remove-sirius-direct branch October 2, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants