forked from AntaresSimulatorTeam/Antares_Simulator
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove sirius direct #176
Open
meslubi2021
wants to merge
83
commits into
Unity-Energy-and-renewable-energy:New-Antares-Emulator-2
Choose a base branch
from
AntaresSimulatorTeam:feature/remove-sirius-direct
base: New-Antares-Emulator-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/remove sirius direct #176
meslubi2021
wants to merge
83
commits into
Unity-Energy-and-renewable-energy:New-Antares-Emulator-2
from
AntaresSimulatorTeam:feature/remove-sirius-direct
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r into solverName + first consequences
Replaced new[] with vectors Made RunTimeInfos static
Mainly add new unit tests for slack analysis. Also add condition (threshold) on slack variable values. --------- Co-authored-by: Florian OMNES <[email protected]> Co-authored-by: Florian Omnès <[email protected]>
9.8-rte1.0 -> 9.10-rte1.0
OR-Tools 9.10-rte1.0 was built with devtoolset-11, so we use the same toolchain to avoid compatibility issues.
Preview https://antares-simulator--2283.org.readthedocs.build/en/2283/user-guide/solver/05-model/#short-term-storage - Notations (variables, parameters) - Added level equation - Contribution to the existing balance equation
Co-authored-by: Jason Marechal <[email protected]> Co-authored-by: Jason Maréchal <[email protected]>
- Add "short-tests" study batch to coverage analysis - Use Release build type for SonarCloud CI (previously Debug) to avoid saturating the RAM on GH runners (Debug + Coverage instrumentation is a bit too much) - (minor) Display error code in case of failure for study tests --------- Co-authored-by: Florian OMNES <[email protected]>
Co-authored-by: Florian Omnès <[email protected]>
reset not resize
https://github.com/marketplace/actions/maximize-build-disk-space ``` Run df -h Filesystem Size Used Avail Use% Mounted on ... /dev/mapper/buildvg-buildlv 85G 24K 85G 1% /home/runner/work/Antares_Simulator/Antares_Simulator ``` Nice
Co-authored-by: Florian Omnès <[email protected]>
- Take overflows into account for hydro ventilation results - Update documentation (typos, etc.) --------- Co-authored-by: Juliette-Gerbaux <[email protected]>
This follows the removal of the "adequacy patch - local matching" feature.
In expressions, replace "AddNode" that takes only 2 operands, with "SumNode" that takes 0 to N operands. This will allow shallower trees. --------- Co-authored-by: Abdoulbari Zaher <[email protected]> Co-authored-by: Florian Omnès <[email protected]>
Co-authored-by: OMNES Florian <[email protected]>
Co-authored-by: OMNES Florian <[email protected]>
Update to properly handle new [or-tools-rte repository](https://github.com/rte-france/or-tools-rte)
Co-authored-by: OMNES Florian <[email protected]>
close #1719 --------- Co-authored-by: Guillaume PIERRE <[email protected]>
Remove unused `SNPRINTF` macro & other defines
output : ![out](https://github.com/user-attachments/assets/d59ee1db-8a49-4cfc-a3f1-ed2c6c503821) legends box-style could match those of the nodes
Co-authored-by: Florian OMNES <[email protected]>
Co-authored-by: Florian OMNES <[email protected]>
Co-authored-by: Florian Omnès <[email protected]>
Co-authored-by: Florian OMNES <[email protected]>
The goal of this PR is to introduce and unit test class **LinearProblemBuilder**. This class is an orchestration class, and therefore makes other classes collaborate. What was done : - Remove **LinearProblemBuilder::solve()** : this method was planned in the specifications, but it extends the builder responsibility scope. Once modified by the builder, the problem can be solved by calling its own **solve()** method. - Add methods **numVariables()** and **numConstraints()** to base class **ILinearProblem** for unit tests reason. - **CMakeLists.txt** file for modeler API was split into 2 **\*.cmake** files - **Trial for a dependency simplification** : In the original / specified architecture, **LinearProblemBuilder** collaborates with classes : - **LinearProblemData** - **ILinearProblem** (interface for LP) - **LinearProblemFiller** : this class also depends on previous classes Here, we allowed ourselves to reduce dependencies of this builder class (is this simplification relevant ?) : class **LinearProblemBuilder** currently only depends on **LinearProblemFiller**, while fillers keeps its planned dependencies on **LinearProblemData** and **ILinearProblem**. Indeed, any filler is in charge to modify problem (using LP data), the but the builder only manipulates fillers. - **Mocking fillers** : fillers are the entities responsible for creating variables and constraints in the linear problem. To do that, they need the LP itself as well as the LP data (see fillers constructor). We created an abstract base filler. All concrete filler inherit from it. Class **LinearProblemBuilder** is constructed from a vector of fillers. - Several unit tests were created for class **LinearProblemBuilder** --------- Co-authored-by: Abdoulbari Zaher <[email protected]>
…ch update (merge from develop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.