Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SG2]Imposter nodes and documents #7865

Open
wants to merge 21 commits into
base: sg2/main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix typos
  • Loading branch information
tracychen1234 committed Apr 28, 2023
commit 2ba3f7dba51cae7931ee5d9985bd9504ed44d852
6 changes: 3 additions & 3 deletions com.unity.sg2/Documentation~/Imposter-UV-Node.md
Original file line number Diff line number Diff line change
@@ -14,11 +14,11 @@ The Imposter UV Node calculates the billboard position and the UV coordinates ne
| Offset | Input | Vector3 | The offset value from the pivot |
| Frame Clipping Threshold | Input | Float | The clamping value for the neighboring frames most useful when parallax mapping is enabled |
| Texture Size | Input | Int | The resolution of the texture. |
| HemiSphere | Input | Boolean | If it's true, calculates the imposter grid and UVs base on hemisphere type.This is Useful if the imposter object will only be seen from above |
| Hemisphere | Input | Boolean | If it's true, calculates the imposter grid and UVs base on hemisphere type.This is Useful if the imposter object will only be seen from above |
| Parallax | Input | Float | Parallax strength, if it equals to 0 than he parallax related control won't affect the outputs.|
| Height map | Input | Texture2D | The height map texture to sample |
| Sampler | Input | Sampler State | The texture sampler to use for sampling the texture |
| Height Map Channel | Input | Int | The channel of the height map to sample for parallax mapping, if any|
| Heightmap Sampler | Input | Sampler State | The texture sampler to use for sampling the texture |
| Heightmap Smaple Channel | Input | Int | The channel of the height map to sample for parallax mapping, if any|
| Out Positon | Output | Vector3 | The output billboard position |
| UV0 | Output | Vector2 | The virtual UV for the base frame |
| UV1 | Output | Vector2 | The virtual UV for the second frame |
6 changes: 3 additions & 3 deletions com.unity.sg2/Documentation~/previews/ImposterUV.md
Original file line number Diff line number Diff line change
@@ -9,10 +9,10 @@ Calculates the billboard positon and the virtual UVs for sampling.
**Offset** - The offset value from the pivot.
**Frame Clipping Threshold** - The clamping value for the neighboring frames most useful when parallax mapping is enabled.
**Texture Size** - The texture resolution.
**Height Map** - The height map texture to sample.
**Sampler** - The texture sampler to use for sampling the texture.
**Heightmap** - The height map texture to sample.
**Heightmap Sampler** - The texture sampler to use for sampling the texture.
**Parallax** - Parallax strength.
**Height Map Channel** - The channle of the height map to sample for parallax mapping, if any.
**Heightmap Sample Channel** - The channle of the height map to sample for parallax mapping, if any.
**HemiSphere** - If it's true, calculates the imposter grid and UVs base on hemisphere type. Useful if the object is only seen from above.

## Output
Original file line number Diff line number Diff line change
@@ -122,16 +122,17 @@ internal class ImposterUVNode : IStandardNode
tooltip: "The size of the imposter"
),
new ParameterUIDescriptor(
name: "HemiSphere",
name: "Hemisphere",
tooltip: "If it's true, calculate imposter grid and UVs base on hemisphere type."
),
new ParameterUIDescriptor(
name: "Texture",
displayName:"Height Map",
displayName:"Heightmap",
tooltip: "The texture asset to sample"
),
new ParameterUIDescriptor(
name: "Sampler",
displayName:"Heightmap Sampler",
tooltip: "The texture sampler to use for sampling the texture"
),
new ParameterUIDescriptor(
@@ -140,7 +141,7 @@ internal class ImposterUVNode : IStandardNode
),
new ParameterUIDescriptor(
name: "HeightMapChannel",
displayName:"Heigh Map Channel",
displayName:"Heighmap Sample Channel",
tooltip: "The texture channel to sample from for the parallax effect"
),
new ParameterUIDescriptor(