-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HDRP Template] Upgrade Input System to 1.8.1 in 3D Sample #8056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add EditorBuildAsset file that references InputSystem_Actions.asset
Currently this file has no reference to the newly created project wide input actions asset in the Assets folder
m_configObjects: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config objects info in EditorBuildSettings looks good - but looks like one extra unnecessary line changes which is probably not needed and may have a side effect. Suggest manually putting that one line back
@@ -6,6 +6,8 @@ EditorBuildSettings: | |||
serializedVersion: 2 | |||
m_Scenes: | |||
- enabled: 1 | |||
path: Assets/SampleSceneAssets/Scenes/SampleScene.unity | |||
path: Assets/Scenes/SampleScene.unity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line change is probably unnecessary AFAICT - can you revert that one line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, can do - the (updated) path is correct though, the old one doesn't exist, is that fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok if that's a correction then great lets land it as is. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the player is set to use both backends, EventSystem no longer throws the errors and a default ProjectWideActions asset is present in the main Assets directory (The only thing that might be a bit odd that It's just a loose file instead of being nested in some Settings folder)
Also, double checked basic uGUI and UIToolkit functionality by creating and checking functionality of buttons, toggles, input fields, etc.
@@ -6,6 +6,8 @@ EditorBuildSettings: | |||
serializedVersion: 2 | |||
m_Scenes: | |||
- enabled: 1 | |||
path: Assets/SampleSceneAssets/Scenes/SampleScene.unity | |||
path: Assets/Scenes/SampleScene.unity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok if that's a correction then great lets land it as is. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed outstanding issues, bumped version and changelog changes!
Purpose of this PR
Testing status
❌ No local testing done yet
Comments to reviewers
Notes for the reviewers you have assigned.