Fix attempt for ISXB-1066 where we still process a hold interaction despite having a more dominant interaction #2055
+141
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue stems from having one of the interaction release early, causing the other to become the dominant interaction, then said other interaction releases. When the first is released, the second takes over and the hold interaction is never processed, leaving it to trigger despite both buttons being released.
Proposed solution is to still process the first interaction to ensure the hold is released.
Testing status & QA
Test case provided under the name
Actions_WithMultipleBindingsAndMultipleInteractions_Works
Overall Product Risks
It fixes the issue but may create a different one.
For instance, if we have two buttons, A and W, bound to the same action, we can do
Press A & W
Release A
Press A
Release W
Since both holds were released, no hold will be triggered.
Comments to reviewers
Current state of the fix is rough, PR mostly to open up to discussion if solution is viable.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: