Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0_ros_setup.md #403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Spice-Weasel
Copy link

Proposed change(s)

docker build and docker run require root privileges - I have added the sudo command to these in order to be consistent with the rest of the setup instructions.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • [ x] Documentation update
  • Other (please describe)

Testing and Verification

Ran commands as normal user without privileges, they fail with permission denied. They need to be added to the docker commands.

Test Configuration:

  • Unity Version: [e.g. Unity 2020.2.0f1]
  • Unity machine OS + version: [Ubuntu 22.04]
  • ROS machine OS + version: [e.g. Ubuntu 18.04, ROS Noetic]
  • ROS–Unity communication: [e.g. Docker]

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • [x ] Updated the documentation as appropriate

Other comments

docker build and docker run require root privileges - I have added the sudo command to these in order to be consistent with the rest of the setup instructions.
@unity-cla-assistant
Copy link

unity-cla-assistant commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants