-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMCL-1436: Integration with the new Cameras Overlay in 23.2 #854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I can't test it until the appropriate Unity version becomes available
I just finished building trunk unity, I am going to test it today or tomorrow. |
There are some interesting edge-cases to look at. For example, what if I have a vcam with no procedural motion on Position (allowing the scene-view camera to drag it), but has a rotation tracking enabled? I would expect to be able to drag the camera's position, but while it's dragging the rotation should update so that it's always looking at the thing I'm tracking. Currently, that doesn't happen, and I have to wait for a refresh after I stop dragging to get the updated rotation. |
a59e868
to
bee950a
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 21.02% 20.98% -0.04%
==========================================
Files 244 245 +1
Lines 27482 27527 +45
==========================================
Hits 5777 5777
- Misses 21705 21750 +45 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thomas, what are the controls to change the FOV and other lens properties via screen view? I can't figure it out
get => Target.Lens.FieldOfView; | ||
set | ||
{ | ||
var currentLens = Target.Lens; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this can be called with a negative number, resulting in negative FOV. In the inspector, this is protected against by calls to Validate() whenever the user changes something. Should the infrastructure be calling Validate() here? Or should the client (i.e. this code) be responsible for it?
Note: If we push a negative value and then undo/redo, Validate() does get called.
Purpose of this PR
Jira ticket: CST-1310
This PR adds allows the new Cameras Overlay to take control of Cinemachine Cameras, which is an Editor only feature. In summary:
This implementation doesn't take constraints into account.
Minimal supported version: Unity 23.2.0a14.
Testing status
[Explanation of what’s tested, how tested and existing or new automation tests. Can include manual testing by self and/or QA. Specify test plans. Rarely acceptable to have no testing.]
Documentation status
[Overview of how documentation is affected by this change. If there is no effect on documentation, explain why. Otherwise, state which sections are changed and why.]
Technical risk
Low. It's scoped to the Cameras Overlay and the Scene View.
Package version
[Justification for updating either the patch, minor, or major version according to the semantic versioning rules]