CMCL-1457: Remove test framework from cinemachine package #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move cinemachine tests into their own package Update tests projects to use cinemachine.tests
AntoineCharton
changed the title
glabute
requested changes
Sep 19, 2023
glabute
reviewed
Sep 19, 2023
| "version": "1.0.0", | ||
| "displayName": "Cinemachine Tests", | ||
| "dependencies": { | ||
| "com.unity.test-framework": "1.1.33" |
There was a problem hiding this comment.
don't we also depend on cinemachine itself?
There was a problem hiding this comment.
According to the doc that is not needed but will check.
{
"name": "com.unity.my-package",
"displayName": "My Package Tests",
"version": "1.2.3",
"type": "tests",
"dependencies": {
"com.unity.my-test-dependency": "1.0.0",
}
}
glabute
changed the title
|
Will probably need @windxu88 input to solve this issue would be great to solve for 3.1.X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Delete any line or section that does not apply]
Purpose of this PR
Remove dependancy to test framework
Testing status
Technical risk
Medium testing changes. Normally no changes in the package though need some manual testing just to be sure.
Comments to reviewers
Check everything is tested correctly. The number of file changed look scary but most of it is just the test folder being moved to an other package.
Package version