CMCL-0000: Fix tests #905
Merged
CMCL-0000: Fix tests #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
=========================================
+ Coverage 0 21.05% +21.05%
=========================================
Files 0 244 +244
Lines 0 27453 +27453
=========================================
+ Hits 0 5779 +5779
- Misses 0 21674 +21674 ☔ View full report in Codecov by Sentry. |
glabute
requested changes
Oct 3, 2023
| "ErrorExceptions": [ | ||
| { | ||
| "ValidationTest": "Unity Version Validation", | ||
| "ExceptionMessage": "In package.json, \"unity\" is pointing to a version higher (2022.3) than the editor you are currently using (2022.2.21f1). Validation needs to happen on a version of the editor that is supported by the package.", |
There was a problem hiding this comment.
I don't understand this fix. The correct thing is to stop testing against 2022.2.
Why is the unity version 2022.2.21f1 hardcoded in the message?
glabute
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Delete any line or section that does not apply]
Purpose of this PR
Fix tests