Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCL-1531: SaveDuringPlay supports multi-scene editing #909

Merged
merged 3 commits into from
Nov 14, 2023
Merged

CMCL-1531: SaveDuringPlay supports multi-scene editing #909

merged 3 commits into from
Nov 14, 2023

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Nov 9, 2023

Purpose of this PR

CMCL-1531: SaveDuringPlay should work with multiple scenes opened using Open Scene Additive.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

AntoineCharton
AntoineCharton approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change!

@glabute glabute merged commit 9e2d555 into main Nov 14, 2023
6 of 8 checks passed
@glabute glabute deleted the dev/SaveDringPlay-supports-multi-scene-editing branch November 14, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineCharton AntoineCharton AntoineCharton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glabute @AntoineCharton