Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: fix upgrader and legacy streaming bugs found in the Enemies demo project. #911

Merged
merged 9 commits into from
Nov 25, 2023

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Nov 22, 2023

Upgrader was crashing when trying to upgrade the Enemies demo project from 3.0.0-pre.4.

Project was still using legacy CinemachineVirtualCamera components, and all the cameras lost their lenses and stopped being animatable when upgrading to anything over CM 3.0.0-pre.4.

@codecov-commenter
Copy link

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (e7ec0e4) 20.98% compared to head (b41d6b3) 21.12%.

Files Patch % Lines
...chine/Editor/Upgrader/CinemachineUpgradeManager.cs 0.00% 70 Missing ⚠️
...nemachine/Runtime/Deprecated/LegacyLensSettings.cs 0.00% 32 Missing ⚠️
....cinemachine/Editor/Upgrader/UpgradeObjectToCm3.cs 0.00% 11 Missing ⚠️
...ine/Runtime/Deprecated/CinemachineVirtualCamera.cs 0.00% 6 Missing ⚠️
...e/Runtime/Behaviours/CinemachineSequencerCamera.cs 0.00% 5 Missing ⚠️
...emachine/Runtime/Deprecated/CinemachineFreeLook.cs 0.00% 5 Missing ⚠️
...machine/Runtime/Behaviours/CinemachineClearShot.cs 20.00% 4 Missing ⚠️
...Runtime/Behaviours/CinemachineStateDrivenCamera.cs 20.00% 4 Missing ⚠️
...chine/Runtime/Core/CinemachineVirtualCameraBase.cs 63.63% 4 Missing ⚠️
.../Editor/Obsolete/CinemachineVirtualCameraEditor.cs 0.00% 3 Missing ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   20.98%   21.12%   +0.13%     
==========================================
  Files         245      245              
  Lines       27527    27458      -69     
==========================================
+ Hits         5777     5800      +23     
+ Misses      21750    21658      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute merged commit 18082a5 into main Nov 25, 2023
8 checks passed
@glabute glabute deleted the dev/legacy-lens-bugs branch November 25, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants