CMCL-0000: Add some missing offsets #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
- Coverage 20.98% 20.96% -0.03%
==========================================
Files 245 245
Lines 27527 27589 +62
==========================================
+ Hits 5777 5784 +7
- Misses 21750 21805 +55 ☔ View full report in Codecov by Sentry. |
glabute
changed the title
|
|
| @@ -13,10 +13,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| ### Added | |||
| - Added CinemachineVirtualCameraBase.CancelDamping() convenience method to snap camera to its target position. | |||
| - Added CinemachineOrbitalFollow.TargetOffset to reposition orbit center. | |||
| - SaveDuringPlay supports multi-scene editing. | |||
| - Added CinemachineGroupFraming.CenterOffset to reposition group ceneter on the screen. | |||
There was a problem hiding this comment.
Added CinemachineGroupFraming.CenterOffset to reposition group center on the screen.
AntoineCharton
approved these changes
Nov 27, 2023
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
HardLookAtTarget was missing a target offset - it always looked at target's root.
GroupFraming was missing a CenterOffset - it always centered the group on the screen.
Added these missing items.