-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCPA-437 hairtab reference #576
Closed
arejayelle
wants to merge
6
commits into
dev/feature/support-hair-workflow
from
DOCPA-437-Hairtab-reference
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2503748
Add Hair section to importer reference
arejayelle f921635
Change text to reference 3 tabs instead of just 2
arejayelle 04cd419
Make hair file independant
arejayelle 294d3d0
Move hair changes into the main file
arejayelle f902fc0
Extra line
arejayelle f4f878a
Tech Writer's 2 cents
sebastienduverne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+10.9 KB
com.unity.formats.alembic/Documentation~/images/abc_import_options_hair.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two others screenshots in this page showing the Model/Material/Hair tabs. They should be also be updated I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this is true! However, I discussed this with @sebastienduverne and the screenshots system will be getting overhauled soon so it's not vital to replace these screenshots yet. The sample information in the current screenshots have is meaningful and therefore it's better to keep these rather than having new images with all 3 tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I remember I said that – however for now there is no immediate plan to retake all screenshots across the doc (for context, it would be to switch to dark mode).
So if one of you could update the 3 consistently (reproduce what was shown as best as possible) and uniformly (get the same width and resolution for all), that would be cleaner. I can't really do it at the moment, I'm not set up for it.
Thanks!