Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: networklist editor memory leak [backport] #3148

Merged
merged 3 commits into from
Dec 2, 2024
Merged

fix: networklist editor memory leak [backport] #3148

merged 3 commits into from
Dec 2, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

This fixes an issue where NetworkList properties could cause a small memory leak if they existing on NetworkBehaviour components placed on an in-scene placed NetworkObject.

fix: #3136

Changelog

  • Fixed: Issue where NetworkList properties on in-scene placed NetworkObjects could cause small memory leaks when entering playmode.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
28ffd3a 
This fixes the issue with NetworkLists on in-scene placed NetworkObjects causing small memory leaks when entering and exiting playmode.
@NoelStephensUnity
update
91a57aa 
adding changelog entry
@NoelStephensUnity
update
5408f78 
adding PR number to log entry
@NoelStephensUnity NoelStephensUnity changed the base branch from develop to release/1.12.0 December 2, 2024 22:07
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review December 2, 2024 22:07
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner December 2, 2024 22:07
@NoelStephensUnity NoelStephensUnity merged commit b404560 into release/1.12.0 Dec 2, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networklist-editor-memoryleak-backport branch December 2, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public NetworkLists potentially being auto instantiated but not disposed leading to a memory leak
1 participant
@NoelStephensUnity