Remove null stream and make the stream inline

Unity-Technologies · Sep 19, 2018 · df1b302 · df1b302
1 parent f698d44
commit df1b302
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/lib/server/command_processor.js b/lib/server/command_processor.js
@@ -9,15 +9,6 @@ const kSource = Symbol("source");
 const kCache = Symbol("cache");
 const kSendFileQueue = Symbol("sendFileQueue");
 
-class NullStream extends Writable {
-    _write(chunk, encoding, cb) {
-        setImmediate(cb);
-    }
-    end(chunk, encoding, cb) {
-        if(cb) setImmediate(cb);
-    }
-}
-
 class CommandProcessor extends Duplex {
 
     /**
@@ -48,7 +39,6 @@ class CommandProcessor extends Duplex {
         this._putWhitelist = this._options.putWhitelist;
         this._whitelistEmpty = (!Array.isArray(this._putWhitelist) || !this._putWhitelist.length);
 
-        this._nullStream = new NullStream();
         this._putStream = null;
         this._putSize = 0;
         this._putSent = 0;
@@ -354,7 +344,11 @@ class CommandProcessor extends Duplex {
         if (this._isWhitelisted(this._trx.clientAddress)) {
             this._putStream = await this._trx.getWriteStream(type, size);
         } else {
-            this._putStream = this._nullStream;
+            this._putStream = new Writable({
+                write(chunk, encoding, cb) {
+                    setImmediate(cb);
+                }
+            });
             helpers.log(consts.LOG_DBG, `PUT rejected from non-whitelisted IP: ${this._trx.clientAddress}`);
         }