Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExampleRobotWrapper for initialization in all examples #265

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Feb 7, 2025

This way the examples are a lot shorter and initialization is the same everywhere, making things easier to maintain.

@urfeex urfeex marked this pull request as draft February 7, 2025 16:22
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 38.23529% with 21 lines in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (b9b9fcf) to head (236a669).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/example_robot_wrapper.cpp 38.23% 13 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   73.65%   72.36%   -1.29%     
==========================================
  Files          80       80              
  Lines        3059     3090      +31     
  Branches      389      397       +8     
==========================================
- Hits         2253     2236      -17     
- Misses        593      636      +43     
- Partials      213      218       +5     
Flag Coverage Δ
ur20-latest 71.00% <35.29%> (-1.12%) ⬇️
ur5-3.14.3 71.89% <38.23%> (-0.87%) ⬇️
ur5e-5.9.4 71.70% <38.23%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urfeex urfeex marked this pull request as ready for review February 10, 2025 09:13
@urfeex urfeex requested a review from a team February 10, 2025 09:13
Copy link

@SarveshMalladi SarveshMalladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some codecov failures that need to be cleared

src/example_robot_wrapper.cpp Show resolved Hide resolved
@urfeex urfeex merged commit f717f83 into UniversalRobots:master Feb 10, 2025
18 of 23 checks passed
@urfeex urfeex deleted the unified_initialization branch February 10, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants