-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use displayException instead of show for showing exceptions #330
Use displayException instead of show for showing exceptions #330
Conversation
Why doesn't this run through CI? |
I'm not sure if it is to do with my having opened a branch from a fork? Or is it perhaps that Travis CI now requires applying for credits for open source projects? |
Yeah, Travis is dead, but there is a GHA CI now: https://github.com/UnkindPartition/tasty/blob/16289a77495eb8279c5e544886ef52503becd148/.github/workflows/ci.yaml |
@adamgundry : I updated the CI triggers. Can you please rebase this onto |
4c87d84
to
ce1078a
Compare
Thanks @andreasabel, looks like it is indeed running now. |
@andreasabel @VictorCMiraldo @martijnbastiaan this looks good to me, any more opinions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A changelog entry would make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me too!
ce1078a
to
de2ffd5
Compare
I've updated changelogs, rebased and merged. Thanks, @adamgundry! |
In case anyone else runs into this: if the exception is raised in a QuickCheck test, the exception is shown in |
Here's my proposed resolution to #327. By calling
displayException
instead ofshow
we get prettier exception output for any exception type that implementsdisplayException
, includingtasty
's version ofHUnitFailure
. (UnfortuntatelyHUnit
's version ofHUnitFailure
doesn't currently implementdisplayException
, but that's aHUnit
issue.)