Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated plugin.py for extract_ass #427

Merged
merged 7 commits into from
Sep 1, 2024
Merged

Conversation

soultaco83
Copy link

fixed extraction codec. Removed the subrip in the codec search that was left

fix extract. Removed the subrip in the codec search that was left
bump version
@Josh5
Copy link
Contributor

Josh5 commented Aug 29, 2024

This is your plugin right?
If so, can you update the info and docs to reflect that you are the maintainer and have links point to your repository for issues and support?

For example, the source for the SRT plugin is here:
https://github.com/Unmanic/plugin.extract_srt_subtitles_to_files

Thanks

@soultaco83
Copy link
Author

@Josh5 You might be able to remove this if you want. I am working on creating a repo for a few plugins that I have modified myself. But I have also updated info.json as requested. And changed the Changelog to reflect this is version 1 of a fork from the extract SRT. Anything else I should change?

@Josh5 Josh5 merged commit 81b13b7 into Unmanic:official Sep 1, 2024
2 checks passed
@Josh5
Copy link
Contributor

Josh5 commented Sep 1, 2024

@soultaco83 all good. Thanks. If you make your own repo and decide to just publish your plugins there, post a message in Discord, and we will help advertise your repo.
If you want me to remove this version down the line, just let me know also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants