fix(filetype): handle missing libmagic library #3790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #3781, the check for availability of the
libmagic
library is not correct. The existing code checks whether themagic
module is available, but the attempt toimport magic
fails if thelibmagic
library is not also available. On the Mac,libmagic
is not installed by default; the user must install it manually, typically viabrew install libmagic
.This PR detects whether
libmagic
is installed by importing themagic
module in atry
block, settingLIBMAGIC_AVAILABLE
accordingly.MAGIC_AVAILABLE
is set to true if themagic
module is installed so that an appropriate warning can be displayed if the fallbackfiletype
module returnsNone
for a mime type. Tests that rely onlibmagic
being installed are skipped if it is not.pytest -v test_unstructured/file_utils
succeeds: